mirror of
https://gitea.com/gitea/gitea-mcp.git
synced 2026-03-14 17:05:14 +00:00
When a Gitea repo is renamed, the API returns a 301 redirect. Go's default `http.Client` follows 301/302/303 redirects by changing the HTTP method from PATCH/POST/PUT to GET and dropping the request body. This causes mutating API calls (edit PR, create issue, etc.) to silently appear to succeed while no write actually occurs — the client receives the current resource data via the redirected GET and returns it as if the edit worked. ## Fix Add a `CheckRedirect` function to both HTTP clients (SDK client in `gitea.go` and REST client in `rest.go`) that returns `http.ErrUseLastResponse` for non-GET/HEAD methods. This surfaces the redirect as an error instead of silently downgrading the request. GET/HEAD reads continue to follow redirects normally. ## Tests - `TestCheckRedirect`: table-driven unit tests for all HTTP methods + redirect limit - `TestDoJSON_RepoRenameRedirect`: regression test with `httptest` server proving PATCH to a 301 endpoint returns an error instead of silently succeeding - `TestDoJSON_GETRedirectFollowed`: verifies GET reads still follow 301 redirects *This PR was authored by Claude.* Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/154 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
176 lines
4.4 KiB
Go
176 lines
4.4 KiB
Go
package gitea
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"crypto/tls"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
"time"
|
|
|
|
mcpContext "gitea.com/gitea/gitea-mcp/pkg/context"
|
|
"gitea.com/gitea/gitea-mcp/pkg/flag"
|
|
)
|
|
|
|
type HTTPError struct {
|
|
StatusCode int
|
|
Body string
|
|
}
|
|
|
|
func (e *HTTPError) Error() string {
|
|
if e.Body == "" {
|
|
return fmt.Sprintf("request failed with status %d", e.StatusCode)
|
|
}
|
|
return fmt.Sprintf("request failed with status %d: %s", e.StatusCode, e.Body)
|
|
}
|
|
|
|
func tokenFromContext(ctx context.Context) string {
|
|
if ctx != nil {
|
|
if token, ok := ctx.Value(mcpContext.TokenContextKey).(string); ok && token != "" {
|
|
return token
|
|
}
|
|
}
|
|
return flag.Token
|
|
}
|
|
|
|
func newRESTHTTPClient() *http.Client {
|
|
transport := http.DefaultTransport.(*http.Transport).Clone()
|
|
if flag.Insecure {
|
|
transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} //nolint:gosec // user-requested insecure mode
|
|
}
|
|
return &http.Client{
|
|
Transport: transport,
|
|
Timeout: 60 * time.Second,
|
|
CheckRedirect: checkRedirect,
|
|
}
|
|
}
|
|
|
|
func buildAPIURL(path string, query url.Values) (string, error) {
|
|
host := strings.TrimRight(flag.Host, "/")
|
|
if host == "" {
|
|
return "", errors.New("gitea host is empty")
|
|
}
|
|
p := strings.TrimLeft(path, "/")
|
|
u, err := url.Parse(fmt.Sprintf("%s/api/v1/%s", host, p))
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if query != nil {
|
|
u.RawQuery = query.Encode()
|
|
}
|
|
return u.String(), nil
|
|
}
|
|
|
|
// DoJSON performs an API request and decodes a JSON response into respOut (if non-nil).
|
|
// It returns the HTTP status code.
|
|
func DoJSON(ctx context.Context, method, path string, query url.Values, body, respOut any) (int, error) {
|
|
var bodyReader io.Reader
|
|
if body != nil {
|
|
b, err := json.Marshal(body)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("marshal request body: %w", err)
|
|
}
|
|
bodyReader = bytes.NewReader(b)
|
|
}
|
|
|
|
u, err := buildAPIURL(path, query)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
req, err := http.NewRequestWithContext(ctx, method, u, bodyReader)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("create request: %w", err)
|
|
}
|
|
|
|
token := tokenFromContext(ctx)
|
|
if token != "" {
|
|
req.Header.Set("Authorization", "token "+token)
|
|
}
|
|
req.Header.Set("Accept", "application/json")
|
|
if body != nil {
|
|
req.Header.Set("Content-Type", "application/json")
|
|
}
|
|
|
|
client := newRESTHTTPClient()
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("do request: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
|
|
bodySnippet, _ := io.ReadAll(io.LimitReader(resp.Body, 8192))
|
|
return resp.StatusCode, &HTTPError{StatusCode: resp.StatusCode, Body: strings.TrimSpace(string(bodySnippet))}
|
|
}
|
|
|
|
if respOut == nil {
|
|
_, _ = io.Copy(io.Discard, resp.Body) // best-effort
|
|
return resp.StatusCode, nil
|
|
}
|
|
|
|
if err := json.NewDecoder(resp.Body).Decode(respOut); err != nil {
|
|
return resp.StatusCode, fmt.Errorf("decode response: %w", err)
|
|
}
|
|
return resp.StatusCode, nil
|
|
}
|
|
|
|
// DoBytes performs an API request and returns the raw response bytes.
|
|
// It returns the HTTP status code.
|
|
func DoBytes(ctx context.Context, method, path string, query url.Values, body any, accept string) ([]byte, int, error) {
|
|
var bodyReader io.Reader
|
|
if body != nil {
|
|
b, err := json.Marshal(body)
|
|
if err != nil {
|
|
return nil, 0, fmt.Errorf("marshal request body: %w", err)
|
|
}
|
|
bodyReader = bytes.NewReader(b)
|
|
}
|
|
|
|
u, err := buildAPIURL(path, query)
|
|
if err != nil {
|
|
return nil, 0, err
|
|
}
|
|
req, err := http.NewRequestWithContext(ctx, method, u, bodyReader)
|
|
if err != nil {
|
|
return nil, 0, fmt.Errorf("create request: %w", err)
|
|
}
|
|
|
|
token := tokenFromContext(ctx)
|
|
if token != "" {
|
|
req.Header.Set("Authorization", "token "+token)
|
|
}
|
|
if accept != "" {
|
|
req.Header.Set("Accept", accept)
|
|
}
|
|
if body != nil {
|
|
req.Header.Set("Content-Type", "application/json")
|
|
}
|
|
|
|
client := newRESTHTTPClient()
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
return nil, 0, fmt.Errorf("do request: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
respBytes, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
return nil, resp.StatusCode, fmt.Errorf("read response: %w", err)
|
|
}
|
|
|
|
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
|
|
bodySnippet := respBytes
|
|
if len(bodySnippet) > 8192 {
|
|
bodySnippet = bodySnippet[:8192]
|
|
}
|
|
return nil, resp.StatusCode, &HTTPError{StatusCode: resp.StatusCode, Body: strings.TrimSpace(string(bodySnippet))}
|
|
}
|
|
|
|
return respBytes, resp.StatusCode, nil
|
|
}
|