mirror of
https://gitea.com/gitea/gitea-mcp.git
synced 2026-03-14 08:55:15 +00:00
0bdf8f5bb3
The `wiki_write` tool exposed the Gitea API's `content_base64` parameter directly, requiring callers to provide base64-encoded content. This caused LLM agents to incorrectly infer that other tools like `create_or_update_file` also require base64 encoding, corrupting files with literal base64 strings. Rename the parameter to `content` (plain text) and handle base64 encoding internally, matching the pattern already used by `create_or_update_file`. Also added test coverage for this. Closes #151 Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/156 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
76 lines
1.8 KiB
Go
76 lines
1.8 KiB
Go
package wiki
|
|
|
|
import (
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
mcpContext "gitea.com/gitea/gitea-mcp/pkg/context"
|
|
"gitea.com/gitea/gitea-mcp/pkg/flag"
|
|
|
|
"github.com/mark3labs/mcp-go/mcp"
|
|
)
|
|
|
|
func TestWikiWriteBase64Encoding(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
method string
|
|
content string
|
|
}{
|
|
{"create ascii", "create", "Hello, World!"},
|
|
{"create unicode", "create", "日本語テスト 🎉"},
|
|
{"create multiline", "create", "line1\nline2\nline3"},
|
|
{"update ascii", "update", "Updated content"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
var gotBody map[string]string
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
body, _ := io.ReadAll(r.Body)
|
|
json.Unmarshal(body, &gotBody)
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.WriteHeader(http.StatusOK)
|
|
w.Write([]byte(`{"title":"test"}`))
|
|
}))
|
|
defer srv.Close()
|
|
|
|
origHost := flag.Host
|
|
flag.Host = srv.URL
|
|
defer func() { flag.Host = origHost }()
|
|
|
|
ctx := context.WithValue(context.Background(), mcpContext.TokenContextKey, "test-token")
|
|
|
|
args := map[string]any{
|
|
"method": tt.method,
|
|
"owner": "org",
|
|
"repo": "repo",
|
|
"content": tt.content,
|
|
"pageName": "TestPage",
|
|
"title": "TestPage",
|
|
}
|
|
|
|
req := mcp.CallToolRequest{}
|
|
req.Params.Arguments = args
|
|
|
|
result, err := wikiWriteFn(ctx, req)
|
|
if err != nil {
|
|
t.Fatalf("wikiWriteFn() error: %v", err)
|
|
}
|
|
if result.IsError {
|
|
t.Fatalf("wikiWriteFn() returned error result")
|
|
}
|
|
|
|
got := gotBody["content_base64"]
|
|
want := base64.StdEncoding.EncodeToString([]byte(tt.content))
|
|
if got != want {
|
|
t.Errorf("content_base64 = %q, want %q", got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|