ai/gitea-mcp
1
0
Fork 0
mirror of https://gitea.com/gitea/gitea-mcp.git synced 2026-03-19 03:15:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

revert: remove unnecessary Content-Type middleware for 202/204

Browse Source 
The Content-Type middleware from #149 is unnecessary because rmcp
already handles 202/204 responses correctly without Content-Type
(returns early before any Content-Type validation). Both Go MCP SDKs
also intentionally omit Content-Type on 202 responses per the MCP spec.

The ErrServerClosed fix from #149 is preserved.

See #148 for the full root cause analysis.

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
This commit is contained in:
silverwind
2026-03-09 14:25:08 +01:00
parent 73263e74d0
commit ed1713636a
2 changed files with 3 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
operation/operation.go
View File

@@ -31,23 +31,6 @@ import (
var mcpServer *server.MCPServer
type noBodyContentTypeResponseWriter struct {
http.ResponseWriter
}
func (w *noBodyContentTypeResponseWriter) WriteHeader(statusCode int) {
if (statusCode == http.StatusAccepted || statusCode == http.StatusNoContent) && w.Header().Get("Content-Type") == "" {
w.Header().Set("Content-Type", "application/json")
}
w.ResponseWriter.WriteHeader(statusCode)
}
func withNoBodyContentType(handler http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
handler.ServeHTTP(&noBodyContentTypeResponseWriter{ResponseWriter: w}, r)
})
}
func RegisterTool(s *server.MCPServer) {
// User Tool
s.AddTools(user.Tool.Tools()...)
@@ -130,16 +113,12 @@ func Run() error {
return err
}
case "http":
mux := http.NewServeMux()
httpServer := &http.Server{Handler: mux}
streamableHTTPServer := server.NewStreamableHTTPServer(
httpServer := server.NewStreamableHTTPServer(
mcpServer,
server.WithLogger(log.New()),
server.WithHeartbeatInterval(30*time.Second),
server.WithHTTPContextFunc(getContextWithToken),
server.WithStreamableHTTPServer(httpServer),
)
mux.Handle("/mcp", withNoBodyContentType(streamableHTTPServer))
log.Infof("Gitea MCP HTTP server listening on :%d", flag.Port)
// Graceful shutdown setup
@@ -152,13 +131,13 @@ func Run() error {
log.Infof("Shutdown signal received, gracefully stopping HTTP server...")
shutdownCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
if err := streamableHTTPServer.Shutdown(shutdownCtx); err != nil {
if err := httpServer.Shutdown(shutdownCtx); err != nil {
log.Errorf("HTTP server shutdown error: %v", err)
}
close(shutdownDone)
}()
if err := streamableHTTPServer.Start(fmt.Sprintf(":%d", flag.Port)); err != nil && !errors.Is(err, http.ErrServerClosed) {
if err := httpServer.Start(fmt.Sprintf(":%d", flag.Port)); err != nil && !errors.Is(err, http.ErrServerClosed) {
return err
}
<-shutdownDone // Wait for shutdown to finish