Awesome/awesome-copilot
1
0
Fork 0
mirror of https://github.com/github/awesome-copilot.git synced 2026-08-01 23:12:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address connector authentication review feedback

Browse Source 
Keep terminal sign-in status retry-safe, preserve operational Azure Identity errors, retry transient legacy-cache cleanup, clarify secure persistence requirements, and fix the blocking spelling check.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Alex Yang (DevDiv)
2026-07-20 14:18:50 -07:00
parent abd06a1c22
commit 59fc5616ec
5 changed files with 106 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/connector-namespaces/auth.mjs
+15 -6
View File
@@ -129,7 +129,13 @@ export class InteractiveAuthBroker {
ensureLegacyCredentialsRemoved() {
if (!this.cleanupInFlight) {
this.cleanupInFlight = Promise.resolve().then(() => this.cleanupLegacyCredentials());
const cleanup = Promise.resolve()
.then(() => this.cleanupLegacyCredentials())
.catch((error) => {
if (this.cleanupInFlight === cleanup) this.cleanupInFlight = null;
throw error;
});
this.cleanupInFlight = cleanup;
}
return this.cleanupInFlight;
}
@@ -198,7 +204,6 @@ export class InteractiveAuthBroker {
if (!session) return { ok: false, status: "unknown" };
if (session.status === "pending") return { ok: true, status: "pending", mode: "interactive" };
this.sessions.delete(sessionId);
if (session.status === "done") return { ok: true, status: "done" };
if (session.status === "cancelled") return { ok: true, status: "cancelled" };
return { ok: false, status: "error", error: session.error || "Azure sign-in failed." };
@@ -224,10 +229,13 @@ export class InteractiveAuthBroker {
credential = this.createInteractiveCredential(authenticationRecord);
this.credential = credential;
} catch (error) {
throw new ConnectorAuthenticationRequiredError(
"Azure sign-in is unavailable. Check the secure token cache installation and try again.",
{ cause: error },
);
if (isAuthenticationRequiredError(error)) {
throw new ConnectorAuthenticationRequiredError(
"Sign in to Azure to continue.",
{ cause: error },
);
}
throw error;
}
}
const request = credential.getToken(this.scope)
@@ -239,6 +247,7 @@ export class InteractiveAuthBroker {
return accessToken.token;
})
.catch((error) => {
if (!isAuthenticationRequiredError(error)) throw error;
if (this.credential === credential) {
this.credential = null;
this.accessToken = null;