mirror of
https://github.com/github/awesome-copilot.git
synced 2026-08-29 12:03:09 +00:00
Add an exact-slug Sentry project resolver to the sentry-triage canvas (#2819)
* Fix sentry-triage canvas crash when the `sentry` package isn't bundled Published awesome-copilot plugins ship extension source only, so the optional `sentry` npm package the canvas depends on at runtime may be absent. Previously that made the canvas crash on open instead of guiding the user through setup. - Load the optional `sentry` package lazily and translate only the top-level ERR_MODULE_NOT_FOUND for `sentry` into a package-missing setup state; any other import failure (missing transitive dep, entrypoint throwing) is rethrown so a real defect isn't masked behind a misleading "reinstall" message. - Add a dedicated package-missing branch to the connection preflight and a matching setup gate, kept distinct from the auth and transient-network gates so the user never sees contradictory guidance. The canvas now opens and explains what to do rather than crashing. - Clear `configured` for the package-missing state so the status is no longer the contradictory `configured:true` + `setup:'package-missing'`. - Tell users to sign in with the package-local CLI via `npx sentry auth login` run from the extension folder — the only form that resolves after a local `npm install`, since a package-local binary isn't on the shell PATH. - Update the README so the sign-in step and install guidance cover the published-plugin layout (`com.github.copilot/extensions/sentry-triage`), not just the standalone user/project extension paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add an exact-slug Sentry project resolver to the sentry-triage canvas The project picker previously only offered projects from the paged list the canvas had already loaded. Teams with many projects (or a project outside the first page) had no way to target one by slug. This adds a verify-on-commit resolver: when a user types a slug that isn't a local match, pressing Enter checks it against Sentry and only commits the canonical slug once verified, so a scan never runs against an unverified or wrong-org project. Canvas / UX (components/page.mjs, styles.mjs): - Autocomplete accepts an exact slug not in the local list; Enter is the explicit commit that triggers resolution (never an as-typed lookup). - A visually-hidden aria-live region announces checking / verified / not found / couldn't-check state, and the resolved state is rendered before commit so screen readers hear the outcome. - Footer/menu surfaces checking, prompt, missing, and error states, including when local partial matches are present. - Project choices are read from an org-keyed cache so a slug from a previously selected org can never be treated as local after a free-text org switch; the stale-completion guard also compares the org captured for the request. Server / resolution (server.mjs, sentry.mjs, sentryClient.mjs, extension.mjs): - CSRF-gated /api/resolve-project verifies a single slug against Sentry. - Resolution runs on the shared serial request chain and is hardened against Sentry outages and queue contention (transient errors are retryable, a confirmed miss is cached as "missing"). Also bumps sentry-triage to 1.1.0 (package.json, plugin.json, marketplace.json). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -2,7 +2,7 @@ import { joinSession, createCanvas } from '@github/copilot-sdk/extension'
|
||||
import { execSync } from 'node:child_process'
|
||||
import { randomUUID } from 'node:crypto'
|
||||
import { startServer } from './server.mjs'
|
||||
import { scanIssues, listOrgs, listProjects } from './sentry.mjs'
|
||||
import { scanIssues, listOrgs, listProjects, findProject } from './sentry.mjs'
|
||||
import { checkConnections, checkConnectionsOnce } from './preflight.mjs'
|
||||
import { sanitizeForPrompt } from './escape.mjs'
|
||||
|
||||
@@ -1160,6 +1160,27 @@ async function discoverProjects(entry, org, { force = false } = {}) {
|
||||
}
|
||||
}
|
||||
|
||||
// Resolve a single exact project slug the user typed, via the SDK's O(1)
|
||||
// project.view (findProject) — the counterpart to discoverProjects's paged,
|
||||
// budget-capped list. For a mega-org the list can't reach every project, so a
|
||||
// valid typed slug may never appear as a suggestion; this confirms it directly.
|
||||
// Returns { found, slug } where slug is the canonical spelling. Throws on a
|
||||
// genuine lookup failure so the server route can answer "could not check"
|
||||
// (ok:false) rather than a misleading "not found".
|
||||
async function resolveProject(entry, org, slug) {
|
||||
if (entry.closed) return { found: false, slug: '' }
|
||||
const orgSlug = String(org || entry.state.getOrg() || entry.state.getOrgDefault() || '').trim().toLowerCase()
|
||||
const wanted = String(slug || '').trim()
|
||||
if (!orgSlug || !wanted) return { found: false, slug: '' }
|
||||
const conn = entry.state.getConnections()
|
||||
// Not reachable means we CANNOT check right now — it is not evidence the project
|
||||
// is missing. Throw so the server route answers "couldn't check" (ok:false)
|
||||
// rather than a false "no such project".
|
||||
if (!conn || !conn.sentry || !conn.sentry.reachable) throw new Error('sentry-unreachable')
|
||||
const resolved = await findProject(orgSlug, wanted)
|
||||
return { found: !!resolved, slug: resolved || '' }
|
||||
}
|
||||
|
||||
async function runConnectionCheck(entry, isCurrent) {
|
||||
try {
|
||||
const connections = await checkConnections()
|
||||
@@ -1962,6 +1983,7 @@ const session = await joinSession({
|
||||
onWorkSelected: (keys, modelByKey, assignCopilot) => onWorkSelected(entry, keys, modelByKey, assignCopilot),
|
||||
onRecheck: () => onRecheckConnections(entry),
|
||||
onListProjects: (org) => discoverProjects(entry, org, { force: true }),
|
||||
onResolveProject: (org, slug) => resolveProject(entry, org, slug),
|
||||
onInvalidateEnrichment: () => {
|
||||
// Bump the scan generation so any enrichment turn still in flight
|
||||
// from the previous repo fails its isCurrent() guard and applies
|
||||
|
||||
Reference in New Issue
Block a user